LayoutTests/fast/dom/Attr/child-nodes-length-cache.html - Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Attr/child-nodes-length-cache.html

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <html>

2 <head>

3 <script>

4 if (window.testRunner)

5 testRunner.dumpAsText();

6

7 function onLoad()

8 {

9 var theDiv = document.getElementById("theDiv");

10 var theAttrs = theDiv.attributes;

11

12 var nameAttr = theAttrs.getNamedItem("name");

13 var nameAttrChildNodes = nameAttr.childNodes;

14 var textNode = document.createTextNode("terday");

15 var unused = nameAttrChildNodes.length;

16 nameAttr.appendChild(textNode);

17

18 var name2Attr = theAttrs.getNamedItem("name2");

19 var name2AttrChildNodes = name2Attr.childNodes;

20 var textNode2 = document.createTextNode("terday");

21 name2Attr.appendChild(textNode2);

22

23 if (nameAttrChildNodes.length != name2AttrChildNodes.length)

24 document.getElementById("result").innerHTML = "Failed: nameAttrChildNode s.length=" + nameAttrChildNodes.length + ", name2AttrChildNodes.length=" + name2 AttrChildNodes.length;

25 else

26 document.getElementById("result").innerHTML = "Passed!!";

27

28 document.body.removeChild(document.getElementById("theDiv"));

29 }

30 </script>

31 </head>

32 <body onload="onLoad();">

33 <p>Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=19759">bug 19759</a >:

34 ChildNodeList for an attribute node is not properly invalidated after appending a child.</p>

35 <div id="theDiv" name="Yes" name2="Yes">Hello</div>

36 <div id="result">Testing...</div>

37 </body>

38 </html>

OLD	NEW