Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1158413004: Added carboard-java library to third_party (Closed)

Created:
5 years, 6 months ago by bajones
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@protobuf_roll
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added carboard-java library to third_party Prerequsite for https://codereview.chromium.org/829803003/ Requires https://codereview.chromium.org/1149283005/ BUG=389343 Committed: https://crrev.com/85d2ceee2ddb325eea9c8c9b99c03c560e14222c Cr-Commit-Position: refs/heads/master@{#334658}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed brettw@'s nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -21 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/cardboard-java/BUILD.gn View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/cardboard-java/LICENSE View 3 chunks +14 lines, -16 lines 0 comments Download
A + third_party/cardboard-java/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A third_party/cardboard-java/README.chromium View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/cardboard-java/cardboard.gyp View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bajones
Brett, could you review this addition to third_party?
5 years, 6 months ago (2015-06-15 22:30:58 UTC) #2
brettw
lgtm https://codereview.chromium.org/1158413004/diff/1/third_party/cardboard-java/BUILD.gn File third_party/cardboard-java/BUILD.gn (right): https://codereview.chromium.org/1158413004/diff/1/third_party/cardboard-java/BUILD.gn#newcode8 third_party/cardboard-java/BUILD.gn:8: java_prebuilt("cardboard_java") { In GN generally the target name ...
5 years, 6 months ago (2015-06-16 17:55:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158413004/20001
5 years, 6 months ago (2015-06-16 18:18:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 19:25:25 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 19:26:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85d2ceee2ddb325eea9c8c9b99c03c560e14222c
Cr-Commit-Position: refs/heads/master@{#334658}

Powered by Google App Engine
This is Rietveld 408576698