Include 'outline' in LayoutSVGBlock::visualOverflowRect

Source/core/layout/svg/LayoutSVGBlock.cpp

Index: Source/core/layout/svg/LayoutSVGBlock.cpp
diff --git a/Source/core/layout/svg/LayoutSVGBlock.cpp b/Source/core/layout/svg/LayoutSVGBlock.cpp
index 43f43cc9c0b7057502f5ddfde8944fa985cccfc2..10ae0ab9b82293c0eaf724844984511d6cdf1407 100644
--- a/Source/core/layout/svg/LayoutSVGBlock.cpp
+++ b/Source/core/layout/svg/LayoutSVGBlock.cpp
@@ -39,10 +39,8 @@ LayoutSVGBlock::LayoutSVGBlock(SVGElement* element)
 LayoutRect LayoutSVGBlock::visualOverflowRect() const

[chrishtr, 2015/06/03 22:12:53]

Is this only ever used in BoxPainter when painting the LayoutSVGRoot? If so, the
coordinate spaces would be the same, and we can also assert.

[fs, 2015/06/04 09:13:31]

No, AFAIK it's only used in BlockPainter (overflowRectForPaintRejection; paint).
LayoutSVGRoot is a different story (inherits from LayoutReplaced) and already
uses LayoutBox::m_overflow. LayoutSVGBlock is only used for <text> and
<foreignObject>.
Not sure what you mean by this, but maybe it's not relevant given the above (and
the new PS).

 {
     LayoutRect borderRect = borderBoxRect();
-
-    if (const ShadowList* textShadow = style()->textShadow())
-        textShadow->adjustRectForShadow(borderRect);
-
+    if (style()->hasVisualOverflowingEffect())
+        borderRect.expand(computeVisualEffectOverflowOutsets());

[chrishtr, 2015/06/02 15:51:05]

LayoutBox computes visual overflow during layout. Why not do the same here? e.g.
during layout, call addVisualEffectOverflow() at the appropriate time, and then
not override this method here, since LayoutBox already stores the rect.

     return borderRect;
 }