Include 'outline' in LayoutSVGBlock::visualOverflowRect

Source/core/layout/svg/LayoutSVGBlock.cpp

 /*
  * Copyright (C) 2006 Apple Computer, Inc.
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 18 matching lines @@
 #include "core/layout/svg/SVGResourcesCache.h"
 #include "core/svg/SVGElement.h"
 
 namespace blink {
 
 LayoutSVGBlock::LayoutSVGBlock(SVGElement* element)
     : LayoutBlockFlow(element)
 {
 }
 
 LayoutRect LayoutSVGBlock::visualOverflowRect() const

[chrishtr, 2015/06/03 22:12:53]

Is this only ever used in BoxPainter when painting the LayoutSVGRoot? If so, the
coordinate spaces would be the same, and we can also assert.

[fs, 2015/06/04 09:13:31]

No, AFAIK it's only used in BlockPainter (overflowRectForPaintRejection; paint).
LayoutSVGRoot is a different story (inherits from LayoutReplaced) and already
uses LayoutBox::m_overflow. LayoutSVGBlock is only used for <text> and
<foreignObject>.
Not sure what you mean by this, but maybe it's not relevant given the above (and
the new PS).

 {
     LayoutRect borderRect = borderBoxRect();
-
-    if (const ShadowList* textShadow = style()->textShadow())
-        textShadow->adjustRectForShadow(borderRect);
-
+    if (style()->hasVisualOverflowingEffect())
+        borderRect.expand(computeVisualEffectOverflowOutsets());

[chrishtr, 2015/06/02 15:51:05]

LayoutBox computes visual overflow during layout. Why not do the same here? e.g.
during layout, call addVisualEffectOverflow() at the appropriate time, and then
not override this method here, since LayoutBox already stores the rect.

     return borderRect;
 }
 
 void LayoutSVGBlock::updateFromStyle()
 {
     LayoutBlock::updateFromStyle();
 
     // LayoutSVGlock, used by Layout(SVGText|ForeignObject), is not allowed to call setHasOverflowClip(true).
     // LayoutBlock assumes a layer to be present when the overflow clip functionality is requested. Both
     // Layout(SVGText|ForeignObject) return 'NoDeprecatedPaintLayer' on 'layerTypeRequired'. Fine for LayoutSVGText.
@@ skipping 68 matching lines @@
 void LayoutSVGBlock::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalidationState)
 {
     if (!shouldCheckForPaintInvalidation(paintInvalidationState))
         return;
 
     ForceHorriblySlowRectMapping slowRectMapping(&paintInvalidationState);
     LayoutBlockFlow::invalidateTreeIfNeeded(paintInvalidationState);
 }
 
 }