Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158323003: Reland: Build a basic Mojo service framework for device/usb (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Build a basic Mojo service framework for device/usb This is a reland of https://codereview.chromium.org/1155163008 now with extra deps to satisfy Win8 GN builds. BUG=492805 TBR=reillyg@chromium.org,sky@chromium.org Committed: https://crrev.com/8fcc275186a815386bf47b0fa3712e87a63ed545 Cr-Commit-Position: refs/heads/master@{#331719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+956 lines, -11 lines) Patch
M chrome/browser/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_device_client.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M device/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M device/core/core.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M device/core/device_client.h View 3 chunks +11 lines, -1 line 0 comments Download
M device/core/device_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
A device/usb/device_impl.h View 1 chunk +44 lines, -0 lines 0 comments Download
A device/usb/device_impl.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A device/usb/device_impl_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl.h View 1 chunk +57 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl_unittest.cc View 1 chunk +174 lines, -0 lines 0 comments Download
A + device/usb/public/cpp/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download
A device/usb/public/cpp/device_manager_delegate.h View 1 chunk +27 lines, -0 lines 0 comments Download
A device/usb/public/cpp/device_manager_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + device/usb/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A device/usb/public/interfaces/device.mojom View 1 chunk +61 lines, -0 lines 0 comments Download
A device/usb/public/interfaces/device_manager.mojom View 1 chunk +38 lines, -0 lines 0 comments Download
A device/usb/type_converters.h View 1 chunk +83 lines, -0 lines 0 comments Download
A device/usb/type_converters.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +32 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158323003/1
5 years, 6 months ago (2015-05-28 01:58:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 02:08:06 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 02:08:54 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8fcc275186a815386bf47b0fa3712e87a63ed545
Cr-Commit-Position: refs/heads/master@{#331719}

Powered by Google App Engine
This is Rietveld 408576698