Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155163008: Build a basic Mojo service framework for device/usb (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build a basic Mojo service framework for device/usb BUG=492805 R=reillyg@chromium.org Committed: https://crrev.com/249cc25c5e0a2e338cd3efec6e1a3964e7c983e9 Cr-Commit-Position: refs/heads/master@{#331707}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments, fix compile errors #

Patch Set 3 : Fix GN dependencies for device_unittests #

Total comments: 3

Patch Set 4 : DISALLOW #

Unified diffs Side-by-side diffs Delta from patch set Stats (+950 lines, -11 lines) Patch
M chrome/browser/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_device_client.cc View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download
M device/BUILD.gn View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M device/core/core.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M device/core/device_client.h View 3 chunks +11 lines, -1 line 0 comments Download
M device/core/device_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A device/usb/device_impl.h View 1 chunk +44 lines, -0 lines 0 comments Download
A device/usb/device_impl.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A device/usb/device_impl_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl.cc View 1 1 chunk +79 lines, -0 lines 0 comments Download
A device/usb/device_manager_impl_unittest.cc View 1 1 chunk +174 lines, -0 lines 0 comments Download
A + device/usb/public/cpp/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download
A device/usb/public/cpp/device_manager_delegate.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A device/usb/public/cpp/device_manager_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + device/usb/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A device/usb/public/interfaces/device.mojom View 1 chunk +61 lines, -0 lines 0 comments Download
A device/usb/public/interfaces/device_manager.mojom View 1 chunk +38 lines, -0 lines 0 comments Download
A device/usb/type_converters.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A device/usb/type_converters.cc View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +32 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (8 generated)
Ken Rockot(use gerrit already)
Please have a gander.
5 years, 7 months ago (2015-05-27 20:15:16 UTC) #1
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1155163008/diff/1/device/usb/device_manager_impl.cc File device/usb/device_manager_impl.cc (right): https://codereview.chromium.org/1155163008/diff/1/device/usb/device_manager_impl.cc#newcode38 device/usb/device_manager_impl.cc:38: usb_service_ = DeviceClient::Get()->GetUsbService(); I would wait until GetDevices() is ...
5 years, 7 months ago (2015-05-27 21:00:53 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1155163008/diff/1/device/usb/device_manager_impl.cc File device/usb/device_manager_impl.cc (right): https://codereview.chromium.org/1155163008/diff/1/device/usb/device_manager_impl.cc#newcode38 device/usb/device_manager_impl.cc:38: usb_service_ = DeviceClient::Get()->GetUsbService(); On 2015/05/27 21:00:52, reillyg wrote: > ...
5 years, 7 months ago (2015-05-27 22:35:04 UTC) #3
Reilly Grant (use Gerrit)
lgtm unless you want to make the factory change. https://codereview.chromium.org/1155163008/diff/40001/device/usb/device_manager_impl_unittest.cc File device/usb/device_manager_impl_unittest.cc (right): https://codereview.chromium.org/1155163008/diff/40001/device/usb/device_manager_impl_unittest.cc#newcode148 device/usb/device_manager_impl_unittest.cc:148: ...
5 years, 7 months ago (2015-05-27 22:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155163008/40001
5 years, 7 months ago (2015-05-27 22:48:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66376)
5 years, 7 months ago (2015-05-27 22:58:02 UTC) #8
Ken Rockot(use gerrit already)
Oops. sky@ could you please take a look at content/browser/OWNERS?
5 years, 7 months ago (2015-05-27 22:59:31 UTC) #10
Ken Rockot(use gerrit already)
Or maybe even chrome/browser/OWNERS...
5 years, 7 months ago (2015-05-27 23:00:31 UTC) #11
sky
LGTM https://codereview.chromium.org/1155163008/diff/40001/chrome/browser/chrome_device_client.cc File chrome/browser/chrome_device_client.cc (right): https://codereview.chromium.org/1155163008/diff/40001/chrome/browser/chrome_device_client.cc#newcode29 chrome/browser/chrome_device_client.cc:29: }; DISALLOW_...
5 years, 7 months ago (2015-05-27 23:01:12 UTC) #12
Ken Rockot(use gerrit already)
Thanks! https://codereview.chromium.org/1155163008/diff/40001/chrome/browser/chrome_device_client.cc File chrome/browser/chrome_device_client.cc (right): https://codereview.chromium.org/1155163008/diff/40001/chrome/browser/chrome_device_client.cc#newcode29 chrome/browser/chrome_device_client.cc:29: }; On 2015/05/27 23:01:11, sky wrote: > DISALLOW_... ...
5 years, 7 months ago (2015-05-27 23:04:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155163008/60001
5 years, 7 months ago (2015-05-27 23:05:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155163008/60001
5 years, 7 months ago (2015-05-27 23:48:21 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-28 00:43:03 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/249cc25c5e0a2e338cd3efec6e1a3964e7c983e9 Cr-Commit-Position: refs/heads/master@{#331707}
5 years, 7 months ago (2015-05-28 00:43:57 UTC) #22
Ken Rockot(use gerrit already)
5 years, 7 months ago (2015-05-28 00:56:06 UTC) #23
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1158323002/ by rockot@chromium.org.

The reason for reverting is: Broken Win8 GN build 

http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/build....

Powered by Google App Engine
This is Rietveld 408576698