Issue 115830: Turn BrowserView::GetBrowserViewForNativeView() into GetBrowserViewForNativeW...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115830: Turn BrowserView::GetBrowserViewForNativeView() into GetBrowserViewForNativeW... (Closed)

Created:
11 years, 7 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turn BrowserView::GetBrowserViewForNativeView() into GetBrowserViewForNativeWindow() This simplifies things on linux where the native window is not the same type as the native view. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17043

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -17 lines)			Patch
M	chrome/browser/browser_focus_uitest.cc	View	2 3	10 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/dock_info_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/browser_bubble_win.cc	View		3 chunks	+5 lines, -2 lines	1 comment	Download
M	chrome/browser/views/frame/browser_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/tabs/dragged_tab_controller.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 7 months ago (2009-05-28 00:03:50 UTC) #2

LGTM with the following change.

http://codereview.chromium.org/115830/diff/15/1016
File chrome/browser/views/browser_bubble_win.cc (right):

http://codereview.chromium.org/115830/diff/15/1016#newcode35
Line 35: gfx::NativeView native_view = frame_->GetNativeView();
I don't think you need native_view here anymore.

Expand Messages | Collapse Messages