Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/views/browser_bubble_win.cc

Issue 115830: Turn BrowserView::GetBrowserViewForNativeView() into GetBrowserViewForNativeW... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dock_info_win.cc ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_bubble_win.cc
===================================================================
--- chrome/browser/views/browser_bubble_win.cc (revision 17018)
+++ chrome/browser/views/browser_bubble_win.cc (working copy)
@@ -7,9 +7,11 @@
#include "app/l10n_util_win.h"
#include "chrome/browser/views/frame/browser_view.h"
#include "views/widget/widget_win.h"
+#include "views/window/window.h"
void BrowserBubble::InitPopup() {
gfx::NativeView native_view = frame_->GetNativeView();
+ gfx::NativeWindow native_window = frame_->GetWindow()->GetNativeWindow();
views::WidgetWin* pop = new views::WidgetWin();
pop->set_delete_on_destroy(false);
pop->set_window_style(WS_POPUP);
@@ -23,7 +25,7 @@
Reposition();
BrowserView* browser_view =
- BrowserView::GetBrowserViewForNativeView(native_view);
+ BrowserView::GetBrowserViewForNativeWindow(native_window);
DCHECK(browser_view);
if (browser_view)
browser_view->AttachBrowserBubble(this);
@@ -31,8 +33,9 @@
void BrowserBubble::DestroyPopup() {
gfx::NativeView native_view = frame_->GetNativeView();
sky 2009/05/28 00:03:50 I don't think you need native_view here anymore.
+ gfx::NativeWindow native_window = frame_->GetWindow()->GetNativeWindow();
BrowserView* browser_view =
- BrowserView::GetBrowserViewForNativeView(native_view);
+ BrowserView::GetBrowserViewForNativeWindow(native_window);
if (browser_view)
browser_view->DetachBrowserBubble(this);
}
« no previous file with comments | « chrome/browser/dock_info_win.cc ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698