mandoline filesystem: Rewrite using base::File.

mandoline filesystem: Rewrite using base::File.

The previous incomplete implementation of the file system targeted posix
semantics. While I'd still like to see a service that offered posix
semantics added to the filesystem application, for short term
cross-platform bring up, rewrite the implementation to targeting
base::File so Windows works.

BUG=490237
Committed: https://crrev.com/6c6729f63ec4fc5063009adb703c2563f08d0464
Cr-Commit-Position: refs/heads/master@{#331994}

[Elliot Glaysher, 2015-05-27 20:45:49]

erg@chromium.org changed reviewers:
+ jam@chromium.org

[Elliot Glaysher, 2015-05-27 20:45:50]

This punts on the windows conversion because I'm getting weird compile failures
inside the autogenerated mojom.h files; I'm waiting on getting my windows
machine so I can actually debug this.

[jam, 2015-05-28 06:40:34]

https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
File components/filesystem/directory_impl.cc (right):

https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
components/filesystem/directory_impl.cc:34: for (base::FilePath name =
directory_enumerator.Next(); !name.empty();
why enumerate twice instead of once with the bitmask set to files+dirs

[yzshen1, 2015-05-28 06:45:14]

> This punts on the windows conversion because I'm getting weird compile
failures
> inside the autogenerated mojom.h files; I'm waiting on getting my windows
> machine so I can actually debug this.

If you would like me to, I could take a look at the compile failures in
mojom.h files.

On Wed, May 27, 2015 at 11:40 PM, <jam@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
> File components/filesystem/directory_impl.cc (right):
>
>
>
https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
> components/filesystem/directory_impl.cc:34: for (base::FilePath name =
> directory_enumerator.Next(); !name.empty();
> why enumerate twice instead of once with the bitmask set to files+dirs
>
> https://codereview.chromium.org/1158253002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elliot Glaysher, 2015-05-28 17:46:58]

ptal

https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
File components/filesystem/directory_impl.cc (right):

https://codereview.chromium.org/1158253002/diff/60001/components/filesystem/d...
components/filesystem/directory_impl.cc:34: for (base::FilePath name =
directory_enumerator.Next(); !name.empty();
On 2015/05/28 06:40:33, jam wrote:
> why enumerate twice instead of once with the bitmask set to files+dirs

Done.

[Elliot Glaysher, 2015-05-28 22:43:00]

ping jam

[jam, 2015-05-29 15:15:18]

lgtm

[Elliot Glaysher, 2015-05-29 16:59:30]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2015-05-29 17:00:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158253002/100001

[commit-bot: I haz the power, 2015-05-29 17:05:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-29 17:06:32]

Patchset 6 (id:??) landed as
https://crrev.com/6c6729f63ec4fc5063009adb703c2563f08d0464
Cr-Commit-Position: refs/heads/master@{#331994}