Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: components/filesystem/public/interfaces/directory.mojom

Issue 1158253002: mandoline filesystem: Rewrite using base::File. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Get the error from the right object. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/futimens_android.cc ('k') | components/filesystem/public/interfaces/file.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/public/interfaces/directory.mojom
diff --git a/components/filesystem/public/interfaces/directory.mojom b/components/filesystem/public/interfaces/directory.mojom
index 9592a3634d8154a114022daae91c650774191554..04c0bc0b9406d6bc299a353b5b8699b38aeeedad 100644
--- a/components/filesystem/public/interfaces/directory.mojom
+++ b/components/filesystem/public/interfaces/directory.mojom
@@ -21,15 +21,6 @@ interface Directory {
// TODO(vtl): Clarify error codes versus |directory_contents|.
Read() => (Error error, array<DirectoryEntry>? directory_contents);
- // Gets information about this directory. On success, |file_information| is
- // non-null and will contain this information.
- Stat() => (Error error, FileInformation? file_information);
-
- // Updates this directory's atime and/or mtime to the time specified by
- // |atime| (or |mtime|, respectively), which may also indicate "now". If
- // |atime| or |mtime| is null, then the corresponding time is not modified.
- Touch(TimespecOrNow? atime, TimespecOrNow? mtime) => (Error error);
-
// Operations *in* "this" |Directory|:
// Opens the file specified by |path| with the given |open_flags|. |file| is
@@ -58,6 +49,4 @@ interface Directory {
// even if the opened directory is subsequently moved -- e.g., closer to the
// "root")
// TODO(vtl): Add a "watch"?
- // TODO(vtl): Should we have a "close" method?
- // TODO(vtl): Add Dup() and Reopen() (like File)?
};
« no previous file with comments | « components/filesystem/futimens_android.cc ('k') | components/filesystem/public/interfaces/file.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698