Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1157943002: Add a setNeedsLayout method to WebPluginContainer. (Closed)

Created:
5 years, 7 months ago by chrishtr
Modified:
5 years, 7 months ago
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a setNeedsLayout method to WebPluginContainer. This allows us to lazily propagate a full layout lifecycle update request for a plugin to the container. Previously, there was no way to indicate a need for a lifecycle update other than paint invalidation. This was a bug, since paint invalidation does not trigger layout, and as a result we could end up with a plugin that tries to paint with stale layout. https://codereview.chromium.org/1158693002 will make use of this CL to replace a call to invalidate() with setNeedsLayout(). BUG=436562 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195908

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M public/web/WebPluginContainer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
chrishtr
5 years, 7 months ago (2015-05-25 23:57:51 UTC) #2
Stephen Chennney
Definitely LGTM.
5 years, 7 months ago (2015-05-26 13:08:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157943002/20001
5 years, 7 months ago (2015-05-26 13:09:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 13:12:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195908

Powered by Google App Engine
This is Rietveld 408576698