Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157843002: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, kalyank, darin (slow to review), ben+mojo_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f Relanding this. Was reverted due to some type conversion errors on Win x64 GN dbg (guess because MSVS 2012?) Just noticed the revert. Will upstream the Mojo fix later. BUG=None TBR=jam@chromium.org Committed: https://crrev.com/7b6d64a6dabbba0f2ce3dd4429fdc79d4aabc898 Cr-Commit-Position: refs/heads/master@{#331246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2822 lines, -4175 lines) Patch
M build/module_args/mojo.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 41 chunks +61 lines, -61 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_clipboard_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/html_viewer/web_cookie_jar_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_logger_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/rev_sdk.py View 3 chunks +14 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_mojo_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_variables.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.h View 2 chunks +36 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 1 chunk +38 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 5 chunks +82 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 15 chunks +102 lines, -27 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 3 chunks +18 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 14 chunks +52 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/raw_channel.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/unique_identifier.h View 4 chunks +12 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/unique_identifier.cc View 3 chunks +22 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/unique_identifier_unittest.cc View 2 chunks +56 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/multiprocess_test_helper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/multiprocess_test_helper.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/scoped_ipc_support.h View 1 chunk +80 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/scoped_ipc_support.cc View 2 chunks +87 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/c/environment/logger.h View 1 chunk +11 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/gles2/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 4 chunks +55 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/union_unittest.cc View 7 chunks +95 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_apptest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/lib/default_logger.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/lib/logging.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/logging.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/tests/logger_unittest.cc View 2 chunks +49 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/tests/logging_unittest.cc View 14 chunks +93 lines, -51 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/BUILD.gn View 1 chunk +37 lines, -23 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/README.md View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/application.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/bindings.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/core.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/internal.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/io.dart View 1 chunk +0 lines, -49 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/application.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/bindings.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/core.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/internal.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/lib/io.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/application.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/application_connection.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/buffer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/codec.dart View 4 chunks +13 lines, -5 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/lib/src/control_message.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/data_pipe.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/drain_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/event_stream.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/handle.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/handle_watcher.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/message.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/message_pipe.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/natives.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/proxy.dart View 3 chunks +65 lines, -0 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/struct.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/stub.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/timer_queue.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mojo/src/mojo/public/dart/lib/src/types.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/pubspec.yaml View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/rules.gni View 10 chunks +108 lines, -8 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/application.dart View 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/application_connection.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/buffer.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/codec.dart View 1 chunk +0 lines, -842 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/data_pipe.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/drain_data.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/event_stream.dart View 1 chunk +0 lines, -249 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/handle.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/handle_watcher.dart View 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/message.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/message_pipe.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/natives.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/proxy.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/struct.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/stub.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/timer_queue.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/mojo/src/mojo/public/dart/src/types.dart View 1 chunk +0 lines, -260 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/decoder.go View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/encoder.go View 2 chunks +22 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +11 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 3 chunks +16 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/BUILD.gn View 4 chunks +21 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java View 2 chunks +5 lines, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/DataHeader.java View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 3 chunks +52 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 7 chunks +45 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageHeader.java View 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Struct.java View 3 chunks +5 lines, -74 lines 0 comments Download
A third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Union.java View 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 5 chunks +9 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl View 4 chunks +16 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 2 chunks +11 lines, -5 lines 0 comments Download
A + third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/encoding_macros.tmpl View 4 chunks +5 lines, -68 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/source.tmpl View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/struct.tmpl View 4 chunks +4 lines, -193 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/union.tmpl View 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl View 1 chunk +367 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/struct.java.tmpl View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 1 chunk +0 lines, -220 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/union.java.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 5 chunks +9 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 7 chunks +14 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_java_generator.py View 6 chunks +24 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 4 chunks +15 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_analyze.py View 2 chunks +4 lines, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/tools/dart_list_mojoms.py View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_list_packages_contents.py View 2 chunks +14 lines, -3 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/dart_package.py View 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/dart_package_name.py View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/dart_pkg.py View 1 chunk +242 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/download_network_service.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/git/dart_pub_get.py View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157843002/1
5 years, 7 months ago (2015-05-24 05:44:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-24 06:18:18 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-24 06:19:20 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7b6d64a6dabbba0f2ce3dd4429fdc79d4aabc898
Cr-Commit-Position: refs/heads/master@{#331246}

Powered by Google App Engine
This is Rietveld 408576698