third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1157843002: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1157843002: Update mojo sdk to rev 1dc8a9a5db73d3718d99917fadf31f5fb2ebad4f (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/union.java.tmpl ('k') | third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 70dc94b5c0ebdfa8a236999f19dbadbe725bb28f..f321c448b0d1393511a2d56444d3890a8352dbbc 100644

--- a/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -230,6 +230,8 @@ def GetCppFieldType(kind):

def GetCppUnionFieldType(kind):

if mojom.IsAnyHandleKind(kind):

return "MojoHandle"

+ if mojom.IsInterfaceKind(kind):

+ return "uint64_t"

if mojom.IsEnumKind(kind):

return "int32_t"

if mojom.IsUnionKind(kind):

@@ -240,7 +242,7 @@ def GetCppUnionFieldType(kind):

def GetUnionGetterReturnType(kind):

if (mojom.IsStructKind(kind) or mojom.IsUnionKind(kind) or

mojom.IsArrayKind(kind) or mojom.IsMapKind(kind) or

- mojom.IsAnyHandleKind(kind)):

+ mojom.IsAnyHandleKind(kind) or mojom.IsInterfaceKind(kind)):

return "%s&" % GetCppWrapperType(kind)

return GetCppResultWrapperType(kind)