Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 11578019: Remove the pools from the ResourceProvider. (Closed)

Created:
8 years ago by ccameron
Modified:
8 years ago
Reviewers:
piman
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Remove the pools from the ResourceProvider. Pools were used in the past and were planned to be used to call deleteOwnedResources. We have moved the responsibility of deleting resources to the structure that created them (for example, the PrioritizedResourceManager now deletes contents textures, instead of calling deleteOwnedResources). BUG=164947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173212

Patch Set 1 #

Patch Set 2 : Re-resolve against head #

Patch Set 3 : Re-resolve against HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -133 lines) Patch
M cc/direct_renderer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/gl_renderer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M cc/prioritized_resource_manager.h View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/prioritized_resource_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/prioritized_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/renderer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/resource_pool.h View 3 chunks +3 lines, -7 lines 0 comments Download
M cc/resource_pool.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M cc/resource_provider.h View 6 chunks +12 lines, -15 lines 0 comments Download
M cc/resource_provider.cc View 9 chunks +17 lines, -31 lines 0 comments Download
M cc/resource_provider_unittest.cc View 6 chunks +8 lines, -33 lines 0 comments Download
M cc/resource_update_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scoped_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scoped_resource.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scoped_resource_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/software_renderer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tile_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ccameron
This removes the concept of ResourceProvider pools. I'll introduce something that the PrioritizedResourceManager uses to ...
8 years ago (2012-12-14 00:06:25 UTC) #1
piman
LGTM, thanks!
8 years ago (2012-12-14 01:48:45 UTC) #2
ccameron
Thanks!!
8 years ago (2012-12-14 01:54:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11578019/1
8 years ago (2012-12-14 01:58:56 UTC) #4
commit-bot: I haz the power
Failed to apply patch for cc/direct_renderer.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-12-14 07:46:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/11578019/25
8 years ago (2012-12-14 08:53:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-14 13:00:51 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-14 17:42:41 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698