Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1157773005: Revert of Add WebRuntimeFeatures::enablePermissionsAPI. (Closed)

Created:
5 years, 6 months ago by samuong
Modified:
5 years, 6 months ago
Reviewers:
timvolodine
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/branch-heads/chromium/2357
Project:
blink
Visibility:
Public.

Description

Revert of Add WebRuntimeFeatures::enablePermissionsAPI. (patchset #1 id:1 of https://codereview.chromium.org/1156113007/) Reason for revert: This change has been applied twice, and is causing compile failures on the following bots (and probably more): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/81064 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/73845 http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/32401 Was this supposed to land on a different branch? Original issue's description: > Add WebRuntimeFeatures::enablePermissionsAPI. > > Add the ability to control whether we want to expose the Permissions API > in blink at runtime. This is e.g. needed for WebView where the > Permissions API is currently not supported. > > BUG=489926 > TBR=dglazkov > NOTRY=true > > Review URL: https://codereview.chromium.org/1150653002 > > git-svn-id: svn://svn.chromium.org/blink/trunk@195691 bbb929c8-8fbe-4397-9dbb-9b2b20218538 > (cherry picked from commit 867b90077485d07fc4dc60de24112bdad2085e6a) > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195998 TBR=timvolodine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489926 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
samuong
Created Revert of Add WebRuntimeFeatures::enablePermissionsAPI.
5 years, 6 months ago (2015-05-27 18:35:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157773005/1
5 years, 6 months ago (2015-05-27 18:36:14 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 18:37:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195999

Powered by Google App Engine
This is Rietveld 408576698