Add WebRuntimeFeatures::enablePermissionsAPI.

Add WebRuntimeFeatures::enablePermissionsAPI.

Add the ability to control whether we want to expose the Permissions API
in blink at runtime. This is e.g. needed for WebView where the
Permissions API is currently not supported.

BUG=489926
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195691

[timvolodine, 2015-05-20 14:11:38]

timvolodine@chromium.org changed reviewers:
+ mkwst@chromium.org

[timvolodine, 2015-05-20 14:17:35]

timvolodine@chromium.org changed reviewers:
+ eisinger@chromium.org

[timvolodine, 2015-05-20 14:17:53]

timvolodine@chromium.org changed reviewers:
+ jochen@chromium.org
- eisinger@chromium.org

[timvolodine, 2015-05-20 18:14:54]

timvolodine@chromium.org changed reviewers:
+ kbr@chromium.org

[timvolodine, 2015-05-20 18:14:55]

+kbr@
(others seem to be OOO)

[Ken Russell (switch to Gerrit), 2015-05-20 19:40:10]

LGTM

[Ken Russell (switch to Gerrit), 2015-05-20 19:40:53]

kbr@chromium.org changed reviewers:
+ chrishtr@chromium.org, dglazkov@chromium.org, japhet@chromium.org

[Ken Russell (switch to Gerrit), 2015-05-20 19:40:53]

Note I'm not an OWNER in public. +more OWNERS.

[dglazkov, 2015-05-20 20:02:06]

https://codereview.chromium.org/1150653002/diff/1/public/web/WebRuntimeFeatur...
File public/web/WebRuntimeFeatures.h (right):

https://codereview.chromium.org/1150653002/diff/1/public/web/WebRuntimeFeatur...
public/web/WebRuntimeFeatures.h:104: BLINK_EXPORT static void
enablePermissions(bool);
enablePermissionsAPI maybe?

[Mike West, 2015-05-21 11:07:45]

I agree with dglazkov@: `enablePermissionsAPI` seems more easily understood.

Where will this flag be used? It's currently not gating any actual code.

[timvolodine, 2015-05-21 11:45:59]

On 2015/05/21 11:07:45, Mike West (holiday in DE) wrote:
> I agree with dglazkov@: `enablePermissionsAPI` seems more easily understood.
> 
> Where will this flag be used? It's currently not gating any actual code.

It's gating IDLs in modules/permissions/, also there is a related content-side
patch here: crrev.com/1144923003

[timvolodine, 2015-05-21 11:46:15]

ptal

https://codereview.chromium.org/1150653002/diff/1/public/web/WebRuntimeFeatur...
File public/web/WebRuntimeFeatures.h (right):

https://codereview.chromium.org/1150653002/diff/1/public/web/WebRuntimeFeatur...
public/web/WebRuntimeFeatures.h:104: BLINK_EXPORT static void
enablePermissions(bool);
On 2015/05/20 20:02:05, dglazkov wrote:
> enablePermissionsAPI maybe?

sure, done.

[dglazkov, 2015-05-21 14:37:25]

lgtm

[Mike West, 2015-05-21 14:39:14]

Sorry, of course. You're not adding a new thing in this patch; you're adding a
public interface to an existing thing. LGTM 2.

[timvolodine, 2015-05-21 15:02:57]

On 2015/05/21 14:39:14, Mike West (holiday in DE) wrote:
> Sorry, of course. You're not adding a new thing in this patch; you're adding a
> public interface to an existing thing. LGTM 2.

thanks!

[timvolodine, 2015-05-21 15:03:02]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2015-05-21 15:03:02]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1150653002/#ps40001
(title: "fix compile")

[commit-bot: I haz the power, 2015-05-21 15:03:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150653002/40001

[commit-bot: I haz the power, 2015-05-21 15:06:48]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195691