Generate PageTransitionTypes.java for Android

Generate PageTransitionTypes.java for Android


BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173372

[boliu, 2012-12-14 02:54:03]

First pass from android reviewers for now

[joth, 2012-12-14 03:22:18]

nice!

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentView.java
(left):

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentView.java:43:
public static final int PAGE_TRANSITION_GENERATED = 5;
oh the horror. same here.

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(left):

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:66:
public static final int PAGE_TRANSITION_START_PAGE = 6;
these are used quite a lot in the internal tree. you may want to leave them here
but @Deprecate, and add a TODO to remove in next patch.

[Yaron, 2012-12-14 03:34:21]

lgtm when joth is happy

https://codereview.chromium.org/11577016/diff/1/android_webview/Android.mk
File android_webview/Android.mk (right):

https://codereview.chromium.org/11577016/diff/1/android_webview/Android.mk#ne...
android_webview/Android.mk:40: # Generated by net.gyp:net_errors_java and
certificate_mime_types_java.
update comment

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(left):

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:66:
public static final int PAGE_TRANSITION_START_PAGE = 6;
On 2012/12/14 03:22:18, joth wrote:
> these are used quite a lot in the internal tree. you may want to leave them
here
> but @Deprecate, and add a TODO to remove in next patch.

+1

[Yaron, 2012-12-14 03:35:41]

It's also pretty sad that these were defined in both ContentView and
ContentViewCore

[boliu, 2012-12-14 05:57:36]

+jam for rest of content

https://codereview.chromium.org/11577016/diff/1/android_webview/Android.mk
File android_webview/Android.mk (right):

https://codereview.chromium.org/11577016/diff/1/android_webview/Android.mk#ne...
android_webview/Android.mk:40: # Generated by net.gyp:net_errors_java and
certificate_mime_types_java.
On 2012/12/14 03:34:21, Yaron wrote:
> update comment

Done.

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentView.java
(left):

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentView.java:43:
public static final int PAGE_TRANSITION_GENERATED = 5;
On 2012/12/14 03:22:18, joth wrote:
> oh the horror. same here.

Done.

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(left):

https://codereview.chromium.org/11577016/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:66:
public static final int PAGE_TRANSITION_START_PAGE = 6;
On 2012/12/14 03:34:21, Yaron wrote:
> On 2012/12/14 03:22:18, joth wrote:
> > these are used quite a lot in the internal tree. you may want to leave them
> here
> > but @Deprecate, and add a TODO to remove in next patch.
> 
> +1

Done.

[jam, 2012-12-14 21:06:23]

lgtm

I find this hard to read because we lose grepping, but there's already precedent
and searching showed me the original email to cr-dev about this, so ignore this
comment :)

[joth, 2012-12-14 22:38:48]

lgtm

[joth, 2012-12-14 22:39:51]

On 2012/12/14 21:06:23, John Abd-El-Malek wrote:
> lgtm
> 
> I find this hard to read because we lose grepping, but there's already
precedent
> and searching showed me the original email to cr-dev about this, so ignore
this
> comment :)

Ah! I've always felt the same about the net errors so prepared
https://codereview.chromium.org/10879058/ back at the time, but no one else
seemed interested. Let me know if you'd like me to try again on that.

[commit-bot: I haz the power, 2012-12-14 22:51:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/11577016/4002

[commit-bot: I haz the power, 2012-12-14 22:52:19]

Presubmit check for 11577016-4002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  android_webview/Android.mk, line 48, 106 chars

Presubmit checks took 4.2s to calculate.

[boliu, 2012-12-14 23:12:39]

Not sure how to turn line length off for that file (also not entirely trivial to
fix). Going to wait for all the trybots go green and dcommit.