content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 11577016: Generate PageTransitionTypes.java for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 11577016: Generate PageTransitionTypes.java for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Deprecate instead of remove old constants. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_common.gypi ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index ea72eea9495ec03ef20b87c6f6301fcb707957fe..3b9bd829073f01f428e5d1ba36b16c662ad2c24a 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -34,13 +34,19 @@ import java.util.ArrayList;

* compatibility.

public class ContentView extends FrameLayout implements ContentViewCore.InternalAccessDelegate {

- // The following constants match the ones in chrome/common/page_transition_types.h.

- // Add more if you need them.

+ // Use PageTransitionLink class instead.

+ // TODO(boliu): Remove these.

+ @Deprecated

public static final int PAGE_TRANSITION_LINK = 0;

+ @Deprecated

public static final int PAGE_TRANSITION_TYPED = 1;

+ @Deprecated

public static final int PAGE_TRANSITION_AUTO_BOOKMARK = 2;

+ @Deprecated

public static final int PAGE_TRANSITION_GENERATED = 5;

+ // TODO(boliu): This diverged from native. Fix this.

+ @Deprecated

public static final int PAGE_TRANSITION_START_PAGE = 6;

// Flag that should be ORed to the page transition when a navigation is initiated from the

// omnibox.

« no previous file with comments | « content/content_common.gypi ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »