Source/core/paint/LayerClipRecorderTest.cpp - Issue 1157653005: Move use of DisplayItemList's vector behind an explicit DisplayItems interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/LayerClipRecorderTest.cpp

Issue 1157653005: Move use of DisplayItemList's vector behind an explicit DisplayItems interface. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: DisplayItems must be noncopyable (Windows build fix) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/paint/DisplayItemListPaintTest.cpp ('k') | Source/core/paint/LayoutObjectDrawingRecorderTest.cpp » ('j') | Source/platform/graphics/paint/DisplayItems.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/LayerClipRecorderTest.cpp

diff --git a/Source/core/paint/LayerClipRecorderTest.cpp b/Source/core/paint/LayerClipRecorderTest.cpp

index 87e3679f159f7a42d1b85374aebb020bcc7060e5..77449e5af986a5fb3841d9dbd2740104746f02c0 100644

--- a/Source/core/paint/LayerClipRecorderTest.cpp

+++ b/Source/core/paint/LayerClipRecorderTest.cpp

@@ -67,9 +67,9 @@ TEST_F(LayerClipRecorderTest, Single)

drawRectInClip(context, layoutView(), PaintPhaseForeground, bound);

rootDisplayItemList().commitNewDisplayItems();

EXPECT_EQ((size_t)3, rootDisplayItemList().displayItems().size());

- EXPECT_TRUE(rootDisplayItemList().displayItems()[0]->isClip());

- EXPECT_TRUE(rootDisplayItemList().displayItems()[1]->isDrawing());

- EXPECT_TRUE(rootDisplayItemList().displayItems()[2]->isEndClip());

+ EXPECT_TRUE(DisplayItem::isClipType(rootDisplayItemList().displayItems()[0].type()));

+ EXPECT_TRUE(DisplayItem::isDrawingType(rootDisplayItemList().displayItems()[1].type()));

+ EXPECT_TRUE(DisplayItem::isEndClipType(rootDisplayItemList().displayItems()[2].type()));

}

TEST_F(LayerClipRecorderTest, Empty)