Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: Source/core/paint/DisplayItemListPaintTest.cpp

Issue 1157653005: Move use of DisplayItemList's vector behind an explicit DisplayItems interface. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: DisplayItems must be noncopyable (Windows build fix) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/DisplayItemListPaintTest.cpp
diff --git a/Source/core/paint/DisplayItemListPaintTest.cpp b/Source/core/paint/DisplayItemListPaintTest.cpp
index 46e4d12d2fcf6895fba811ace5ce6ecf1b448796..3eb3e6f5e8ac61eb81700e6925620d4ce0f1ae42 100644
--- a/Source/core/paint/DisplayItemListPaintTest.cpp
+++ b/Source/core/paint/DisplayItemListPaintTest.cpp
@@ -31,7 +31,7 @@ public:
protected:
LayoutView& layoutView() { return *m_layoutView; }
DisplayItemList& rootDisplayItemList() { return *layoutView().layer()->graphicsLayerBacking()->displayItemList(); }
- const Vector<OwnPtr<DisplayItem>>& newPaintListBeforeUpdate() { return rootDisplayItemList().m_newDisplayItems; }
+ const DisplayItems& newPaintListBeforeUpdate() { return rootDisplayItemList().m_newDisplayItems; }
private:
virtual void SetUp() override
@@ -76,9 +76,9 @@ public:
break; \
const TestDisplayItem expected[] = { __VA_ARGS__ }; \
for (size_t index = 0; index < std::min<size_t>(actual.size(), expectedSize); index++) { \
- TRACE_DISPLAY_ITEMS(index, expected[index], *actual[index]); \
- EXPECT_EQ(expected[index].client(), actual[index]->client()); \
- EXPECT_EQ(expected[index].type(), actual[index]->type()); \
+ TRACE_DISPLAY_ITEMS(index, expected[index], actual[index]); \
+ EXPECT_EQ(expected[index].client(), actual[index].client()); \
+ EXPECT_EQ(expected[index].type(), actual[index].type()); \
} \
} while (false);
« no previous file with comments | « no previous file | Source/core/paint/LayerClipRecorderTest.cpp » ('j') | Source/platform/graphics/paint/DisplayItems.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698