Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1157633003: Revert of Re-proc SkBlitRow::Color32 for ARM. (Closed)

Created:
5 years, 7 months ago by mtklein
Modified:
5 years, 7 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Re-proc SkBlitRow::Color32 for ARM. (patchset #3 id:40001 of https://codereview.chromium.org/1145283003/) Reason for revert: http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/70016/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Re-proc SkBlitRow::Color32 for ARM. > > This is a spiritual revert of http://crrev.com/1104183004. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4e13a23d8f720e17660f26657b45b89fe4339004 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b8d9f776e476746b38c0dca674e497d7c4b13cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M include/core/SkBlitRow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Re-proc SkBlitRow::Color32 for ARM.
5 years, 7 months ago (2015-05-22 12:51:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157633003/1
5 years, 7 months ago (2015-05-22 12:51:32 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 12:51:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3b8d9f776e476746b38c0dca674e497d7c4b13cb

Powered by Google App Engine
This is Rietveld 408576698