Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: build/build_nexe.py

Issue 11576019: build_nexe.py: Allow --strip-debug for archives (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/build_nexe.py
diff --git a/build/build_nexe.py b/build/build_nexe.py
index 7c068f78efa90ab199a93d9ed6ceb36313f9d107..e2dcb35bd4b7588b185324d5dae6bd5af84a7ff7 100644
--- a/build/build_nexe.py
+++ b/build/build_nexe.py
@@ -495,7 +495,10 @@ class Builder(object):
if self.strip_all or self.strip_debug:
self.Strip(out)
elif self.outtype in ['nlib', 'plib']:
- self.Archive(srcs)
+ out = self.Archive(srcs)
+ # Also valid to strip archives, but strip_all seems dangerous.
Roland McGrath 2012/12/13 20:51:39 Indeed, --strip-all makes .a or .o files unusable.
+ if self.strip_debug:
Sam Clegg 2012/12/13 20:55:58 This seems a little confusing to me. If I specify
jvoung - send to chromium... 2012/12/13 21:23:23 Yeah, it shouldn't do less that strip-debug... Ok
+ self.Strip(out)
else:
ErrOut('FAILED: Unknown outtype %s:\n' % (self.outtype))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698