build_nexe.py: Allow --strip-debug for archives

build/build_nexe.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from optparse import OptionParser
 import os
 import subprocess
 import sys
 import tempfile
@@ skipping 477 matching lines @@
   def Generate(self, srcs):
     """Generate final output file.
 
     Link or Archive the final output file, from the compiled sources.
     """
     if self.outtype in ['nexe', 'pexe', 'nso']:
       out = self.Link(srcs)
       if self.strip_all or self.strip_debug:
         self.Strip(out)
     elif self.outtype in ['nlib', 'plib']:
-      self.Archive(srcs)
+      out = self.Archive(srcs)
+      # Also valid to strip archives, but strip_all seems dangerous.

[Roland McGrath, 2012/12/13 20:51:39]

Indeed, --strip-all makes .a or .o files unusable.
--strip-debug is fine for them.

+      if self.strip_debug:

[Sam Clegg, 2012/12/13 20:55:58]

This seems a little confusing to me.

If I specify strip-all on a archive I would expect it to at least strip debug
info, rather than do nothing.  But stripping everything and having it fail
wouldn't be so bad either since it would force me to do the right thing.

[jvoung - send to chromium..., 2012/12/13 21:23:23]

Yeah, it shouldn't do less that strip-debug...
Ok I'll pass strip-all straight through so that people can do the right thing in
the gyp files.

+        self.Strip(out)
     else:
       ErrOut('FAILED: Unknown outtype %s:\n' % (self.outtype))
 
 
 def Main(argv):
   parser = OptionParser()
   parser.add_option('--empty', dest='empty', default=False,
                     help='Do not pass sources to library.', action='store_true')
   parser.add_option('--no-suffix', dest='suffix', default=True,
                     help='Do not append arch suffix.', action='store_false')
@@ skipping 64 matching lines @@
     out = build.Compile(filename)
     if out:
       objs.append(out)
   # Do not link if building an object
   if not options.compile_only:
     build.Generate(objs)
   return 0
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))