Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 11576003: [content shell] run headless when in layout test mode (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)
Modified:
8 years ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] run headless when in layout test mode Currently only for gtk. There's also a command line flag --show-content-shell which overrides this for debugging BUG=111316 TEST=nothing should change R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173751

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M content/shell/shell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/shell.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download
M content/shell/shell_gtk.cc View 1 7 chunks +22 lines, -2 lines 0 comments Download
M content/shell/shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
8 years ago (2012-12-13 09:25:42 UTC) #1
marja
lgtm
8 years ago (2012-12-13 09:26:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11576003/1
8 years ago (2012-12-13 09:27:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests
8 years ago (2012-12-13 11:02:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11576003/11001
8 years ago (2012-12-18 16:36:42 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-18 18:03:54 UTC) #6
Message was sent while issue was closed.
Change committed as 173751

Powered by Google App Engine
This is Rietveld 408576698