Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1157563004: Revert of Update Blink to use the tree scope info on WebFrame for scoping checks. (Closed)

Created:
5 years, 7 months ago by tkent
Modified:
5 years, 7 months ago
Reviewers:
hayato, dcheng
CC:
dcheng, blink-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Update Blink to use the tree scope info on WebFrame for scoping checks. (patchset #2 id:20001 of https://codereview.chromium.org/1141553006/) Reason for revert: Broke Android build. https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/45207 Original issue's description: > Update Blink to use the tree scope info on WebFrame for scoping checks. > > This patch switches FrameTree over to using the tree scope information > that's now tracked in WebFrame. This removes the dependency on using the > DOM to check if a nested browsing context is in a shadow tree, so the > scoping checks for remote frames can be re-enabled. > > The rest of this change is just updating callsites for functions with > new signatures, as well as deleting now-obsolete code. > > BUG=473518 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195765 TBR=hayato@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=473518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -62 lines) Patch
M Source/core/frame/LocalFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/page/FrameTree.cpp View 1 chunk +46 lines, -18 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 18 chunks +27 lines, -27 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebRemoteFrame.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Update Blink to use the tree scope info on WebFrame for scoping ...
5 years, 7 months ago (2015-05-22 06:53:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157563004/1
5 years, 7 months ago (2015-05-22 06:53:30 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 06:54:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195768

Powered by Google App Engine
This is Rietveld 408576698