public/web/WebFrameClient.h - Issue 1157563004: Revert of Update Blink to use the tree scope info on WebFrame for scoping checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 1157563004: Revert of Update Blink to use the tree scope info on WebFrame for scoping checks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 1de7df29d595279f9b1c92d9de8619fe6e361a81..0fa1f0b522b883f6d39ae95ebf411abbdd5d20c3 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -150,6 +150,8 @@

// Note: If you override this, you should almost certainly be overriding

// frameDetached().

virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }

+ // TODO(dcheng): Remove this overload, since it's deprecated.

+ virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }

// This frame set its opener to null, disowning it.

// See http://html.spec.whatwg.org/#dom-opener.

« no previous file with comments | « Source/web/tests/WebViewTest.cpp ('k') | public/web/WebLocalFrame.h » ('j') | no next file with comments »