Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1157543004: Debugger: PreservePositionScope should clear positions inside the scope. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: PreservePositionScope should clear positions inside the scope. The point of this change is so that when emitting code for a call in FullCodegen::VisitCall, the statement position is not associated to any code that loads the function, but to the actual CallIC. R=mvstanton@chromium.org BUG=chromium:481896 LOG=N Committed: https://crrev.com/3f223ee69bdf66c31a1f0b340a8124834b82f93d Cr-Commit-Position: refs/heads/master@{#28701}

Patch Set 1 #

Patch Set 2 : only break at inline caches if it owns a statement position. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -9 lines) Patch
M src/assembler.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/debug.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.cc View 1 5 chunks +14 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-481896.js View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 6 months ago (2015-05-28 14:29:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157543004/20001
5 years, 6 months ago (2015-05-29 07:23:22 UTC) #3
mvstanton
lgtm
5 years, 6 months ago (2015-05-29 07:37:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 07:48:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157543004/20001
5 years, 6 months ago (2015-05-29 12:55:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-29 12:56:30 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 12:56:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f223ee69bdf66c31a1f0b340a8124834b82f93d
Cr-Commit-Position: refs/heads/master@{#28701}

Powered by Google App Engine
This is Rietveld 408576698