Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: src/assembler.h

Issue 1157543004: Debugger: PreservePositionScope should clear positions inside the scope. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: only break at inline caches if it owns a statement position. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.h
diff --git a/src/assembler.h b/src/assembler.h
index fd66e0bfdb111b22c74f562cae1640c191481c2f..d5822395b954acf34144d43c8128e16c926f7d45 100644
--- a/src/assembler.h
+++ b/src/assembler.h
@@ -1112,7 +1112,11 @@ class PreservePositionScope BASE_EMBEDDED {
public:
explicit PreservePositionScope(PositionsRecorder* positions_recorder)
: positions_recorder_(positions_recorder),
- saved_state_(positions_recorder->state_) {}
+ saved_state_(positions_recorder->state_) {
+ // Reset positions so that previous ones do not accidentally get
+ // recorded within this scope.
+ positions_recorder->state_ = PositionState();
+ }
~PreservePositionScope() {
positions_recorder_->state_ = saved_state_;
« no previous file with comments | « no previous file | src/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698