[rAc] [OSX] Use vertically compact text to show suggestions, when it fits.

[rAc] [OSX] Use vertically compact text to show suggestions, when it fits.

BUG=279563
TEST=Shorter addresses should fit on a single line; longer addresses should
     still span many lines.
R=groby@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241110

[groby-ooo-7-16, 2013-12-14 04:39:18]

LGTM unless you want to take my suggestion and move the logic.

https://codereview.chromium.org/115753002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/autofill/autofill_section_container.mm (right):

https://codereview.chromium.org/115753002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_section_container.mm:315: if
([suggestContainer_ preferredSize].width > kDetailsWidth) {
Shouldn't that logic just happen in the suggestContainer_?  It's odd to set the
string, ask for the preferredSize, and then change our mind...

Ideally, we wouldn't even need two strings. Just remove the line breaks, try if
that fits on a single line. If it doesn't, take the original text.

[Ilya Sherman, 2013-12-14 05:02:26]

https://codereview.chromium.org/115753002/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/autofill/autofill_section_container.mm (right):

https://codereview.chromium.org/115753002/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/autofill/autofill_section_container.mm:315: if
([suggestContainer_ preferredSize].width > kDetailsWidth) {
On 2013/12/14 04:39:19, groby wrote:
> Shouldn't that logic just happen in the suggestContainer_?  It's odd to set
the
> string, ask for the preferredSize, and then change our mind...
> 
> Ideally, we wouldn't even need two strings. Just remove the line breaks, try
if
> that fits on a single line. If it doesn't, take the original text. 

Done.

[commit-bot: I haz the power, 2013-12-14 06:16:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/115753002/80001

[commit-bot: I haz the power, 2013-12-14 06:48:36]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 20:12:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/115753002/80001

[commit-bot: I haz the power, 2013-12-17 02:19:26]

Change committed as 241110