Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h

Issue 115753002: [rAc] [OSX] Use vertically compact text to show suggestions, when it fits. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix wording a bit Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h b/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h
index 95b94464a9d754ae2d00fe9b46937f9e5be0d05c..0d964a178c190a5e4b8a836c63527a8ace6a35a2 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h
+++ b/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container.h
@@ -34,8 +34,18 @@ namespace autofill {
// Auxiliary textfield. See showInputField: for details.
@property (readonly, nonatomic) AutofillTextField* inputField;
-// Set the main suggestion text and the corresponding |icon|.
-- (void)setSuggestionText:(NSString*)line icon:(NSImage*)icon;
+// Set the main suggestion text and the corresponding |icon|. The text is set to
+// |verticallyCompactText| if that can fit without wrapping. Otherwise, the text
+// is set to |horizontallyCompactText|, with possibly additional wrapping
+// imposed by the dialog's size constraints.
+// NOTE: The implementation assumes that all other elements' sizes are already
+// known. Hence, -showInputField:withIcon: should be called prior to calling
+// this method, if it is going to be called at all.
+- (void)
+ setSuggestionWithVerticallyCompactText:(NSString*)verticallyCompactText
+ horizontallyCompactText:(NSString*)horizontallyCompactText
+ icon:(NSImage*)icon
+ maxWidth:(CGFloat)maxWidth;
// Shows an auxiliary textfield to the right of the suggestion icon and
// text. This is currently only used to show a CVC field for the CC section.

Powered by Google App Engine
This is Rietveld 408576698