For the values defined in the loop and spilled outside sink spill store out of the loop down to loo…

src/hydrogen.cc

Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 97306a165963da9aff7824321404240b0bb2b5b2..c8b97031b49c8d4acc186f7bea08ea9ef8664338 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -678,8 +678,14 @@ HBasicBlock* HGraphBuilder::CreateLoop(IterationStatement* statement,
   if (break_block != NULL) {
     if (loop_successor != NULL) loop_successor->Goto(break_block);
     break_block->SetJoinId(statement->ExitId());
+    if (loop_entry->IsLoopHeader()) {
+      loop_entry->loop_information()->set_exit_block(break_block);
+    }
     return break_block;
   }
+  if (loop_entry->IsLoopHeader()) {
+    loop_entry->loop_information()->set_exit_block(loop_successor);
+  }

[danno, 2013/01/10 15:33:27]

a bit of a nit, but how about just setting exit_block to either break_block or
loop_successor and then:

if (loop_entry->IsLoopHeader()) {
  loop_entry->loop_information()->set_exit_block(exit_block);
}
return exit_block;

[Vyacheslav Egorov (Google), 2013/01/25 13:49:17]

Done.

   return loop_successor;
 }