For the values defined in the loop and spilled outside sink spill store out of the loop down to loo…

src/hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 660 matching lines @@
 HBasicBlock* HGraphBuilder::CreateLoop(IterationStatement* statement,
                                        HBasicBlock* loop_entry,
                                        HBasicBlock* body_exit,
                                        HBasicBlock* loop_successor,
                                        HBasicBlock* break_block) {
   if (body_exit != NULL) body_exit->Goto(loop_entry);
   loop_entry->PostProcessLoopHeader(statement);
   if (break_block != NULL) {
     if (loop_successor != NULL) loop_successor->Goto(break_block);
     break_block->SetJoinId(statement->ExitId());
+    if (loop_entry->IsLoopHeader()) {
+      loop_entry->loop_information()->set_exit_block(break_block);
+    }
     return break_block;
   }
+  if (loop_entry->IsLoopHeader()) {
+    loop_entry->loop_information()->set_exit_block(loop_successor);
+  }

[danno, 2013/01/10 15:33:27]

a bit of a nit, but how about just setting exit_block to either break_block or
loop_successor and then:

if (loop_entry->IsLoopHeader()) {
  loop_entry->loop_information()->set_exit_block(exit_block);
}
return exit_block;

[Vyacheslav Egorov (Google), 2013/01/25 13:49:17]

Done.

   return loop_successor;
 }
 
 
 void HBasicBlock::FinishExit(HControlInstruction* instruction) {
   Finish(instruction);
   ClearEnvironment();
 }
 
 
@@ skipping 9423 matching lines @@
     }
   }
 
 #ifdef DEBUG
   if (graph_ != NULL) graph_->Verify(false);  // No full verify.
   if (allocator_ != NULL) allocator_->Verify();
 #endif
 }
 
 } }  // namespace v8::internal