Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 11575030: For the values defined in the loop and spilled outside sink spill store out of the loop down to loo… (Closed)

Created:
8 years ago by Vyacheslav Egorov (Google)
Modified:
5 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

For the values defined in the loop and spilled outside sink spill store out of the loop down to loop exit whenever possible. BUG=v8:2450

Patch Set 1 #

Total comments: 12

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -24 lines) Patch
M src/hydrogen.h View 1 4 chunks +12 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
M src/lithium-allocator.h View 1 7 chunks +41 lines, -4 lines 0 comments Download
M src/lithium-allocator.cc View 1 7 chunks +124 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
Another tight loops improvement in the register allocator that was sitting on my table for ...
8 years ago (2012-12-14 16:31:07 UTC) #1
danno
https://codereview.chromium.org/11575030/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/11575030/diff/1/src/hydrogen.cc#newcode688 src/hydrogen.cc:688: } a bit of a nit, but how about ...
7 years, 11 months ago (2013-01-10 15:33:27 UTC) #2
Vyacheslav Egorov (Google)
PTAL https://codereview.chromium.org/11575030/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/11575030/diff/1/src/hydrogen.cc#newcode688 src/hydrogen.cc:688: } On 2013/01/10 15:33:27, danno wrote: > a ...
7 years, 11 months ago (2013-01-25 13:49:16 UTC) #3
danno
7 years, 10 months ago (2013-02-01 11:41:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698