Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157463002: Simplify UnicodeRangeToken handling (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify UnicodeRangeToken handling Instead of building a CSSValueList, we can just copy the UChar32 pair like in CSSParserToken. This also helps in transition in CSSPropertyParser to use CSSParserToken instead of CSSParserValue. BUG=489144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195792

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M Source/core/css/parser/CSSParserValues.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.cpp View 1 1 chunk +4 lines, -13 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rwlbuis
PTAL. The patch is optional of course.
5 years, 7 months ago (2015-05-22 01:07:01 UTC) #2
Timothy Loh
ok lgtm https://codereview.chromium.org/1157463002/diff/20001/Source/core/css/parser/CSSParserValues.h File Source/core/css/parser/CSSParserValues.h (right): https://codereview.chromium.org/1157463002/diff/20001/Source/core/css/parser/CSSParserValues.h#newcode127 Source/core/css/parser/CSSParserValues.h:127: // Represents a unicode range by a ...
5 years, 7 months ago (2015-05-22 01:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157463002/40001
5 years, 7 months ago (2015-05-22 13:44:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 15:38:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195792

Powered by Google App Engine
This is Rietveld 408576698