Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1157463002: Simplify UnicodeRangeToken handling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSParserValues.cpp
diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp
index eddad768cacdc3f3a8b0514c3c5636fb095d16e2..be86e3292fdd4590efe0bf840a5ff8f16a6b892e 100644
--- a/Source/core/css/parser/CSSParserValues.cpp
+++ b/Source/core/css/parser/CSSParserValues.cpp
@@ -162,20 +162,11 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range, bool& usesRemU
value.isInt = (token.numericValueType() == IntegerValueType);
break;
case UnicodeRangeToken: {
- value.unit = CSSParserValue::UnicodeRange;
- CSSParserValueList* list = new CSSParserValueList;
- value.valueList = list;
value.id = CSSValueInvalid;
-
- CSSParserValue start;
- start.setFromNumber(token.unicodeRangeStart());
- start.isInt = true;
- list->addValue(start);
-
- CSSParserValue end;
- end.setFromNumber(token.unicodeRangeEnd());
- end.isInt = true;
- list->addValue(end);
+ value.isInt = false;
+ value.m_unicodeRange.start = token.unicodeRangeStart();
+ value.m_unicodeRange.end = token.unicodeRangeEnd();
+ value.unit = CSSParserValue::UnicodeRange;
break;
}
case HashToken:
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698