src/x64/lithium-codegen-x64.cc - Issue 1157423003: [x64] Fix useless deopt in for-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 1157423003: [x64] Fix useless deopt in for-in. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index b9b6abac7152c02127c5b4358e3a3dfd08a1c239..1aaae6aa8776a29732d39b119911c851f8147ab5 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -5884,8 +5884,6 @@ void LCodeGen::DoOsrEntry(LOsrEntry* instr) {

void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {

DCHECK(ToRegister(instr->context()).is(rsi));

- DeoptimizeIf(equal, instr, Deoptimizer::kNull);

Condition cc = masm()->CheckSmi(rax);

DeoptimizeIf(cc, instr, Deoptimizer::kSmi);

« no previous file with comments | « no previous file | no next file » | no next file with comments »