Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 1157423003: [x64] Fix useless deopt in for-in. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 5866 matching lines...) Expand 10 before | Expand all | Expand 10 after
5877 DCHECK(!environment->HasBeenRegistered()); 5877 DCHECK(!environment->HasBeenRegistered());
5878 RegisterEnvironmentForDeoptimization(environment, Safepoint::kNoLazyDeopt); 5878 RegisterEnvironmentForDeoptimization(environment, Safepoint::kNoLazyDeopt);
5879 5879
5880 GenerateOsrPrologue(); 5880 GenerateOsrPrologue();
5881 } 5881 }
5882 5882
5883 5883
5884 void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) { 5884 void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {
5885 DCHECK(ToRegister(instr->context()).is(rsi)); 5885 DCHECK(ToRegister(instr->context()).is(rsi));
5886 5886
5887 DeoptimizeIf(equal, instr, Deoptimizer::kNull);
5888
5889 Condition cc = masm()->CheckSmi(rax); 5887 Condition cc = masm()->CheckSmi(rax);
5890 DeoptimizeIf(cc, instr, Deoptimizer::kSmi); 5888 DeoptimizeIf(cc, instr, Deoptimizer::kSmi);
5891 5889
5892 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 5890 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
5893 __ CmpObjectType(rax, LAST_JS_PROXY_TYPE, rcx); 5891 __ CmpObjectType(rax, LAST_JS_PROXY_TYPE, rcx);
5894 DeoptimizeIf(below_equal, instr, Deoptimizer::kWrongInstanceType); 5892 DeoptimizeIf(below_equal, instr, Deoptimizer::kWrongInstanceType);
5895 5893
5896 Label use_cache, call_runtime; 5894 Label use_cache, call_runtime;
5897 Register null_value = rdi; 5895 Register null_value = rdi;
5898 __ LoadRoot(null_value, Heap::kNullValueRootIndex); 5896 __ LoadRoot(null_value, Heap::kNullValueRootIndex);
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
6027 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6025 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6028 RecordSafepoint(Safepoint::kNoLazyDeopt); 6026 RecordSafepoint(Safepoint::kNoLazyDeopt);
6029 } 6027 }
6030 6028
6031 6029
6032 #undef __ 6030 #undef __
6033 6031
6034 } } // namespace v8::internal 6032 } } // namespace v8::internal
6035 6033
6036 #endif // V8_TARGET_ARCH_X64 6034 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698