Issue 1157423003: [x64] Fix useless deopt in for-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157423003: [x64] Fix useless deopt in for-in. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer

Modified:
5 years, 6 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[x64] Fix useless deopt in for-in. R=jarin@chromium.org Committed: https://crrev.com/b749a19570ce33a41e4cc792c19b4b21fdecbc71 Cr-Commit-Position: refs/heads/master@{#28692}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (1 generated)

Benedikt Meurer

Hey Jaro, Yeah Crankshaft... I know... but this was so obviously wrong, I had to ...

5 years, 6 months ago (2015-05-28 17:43:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157423003/20001

5 years, 6 months ago (2015-05-29 06:03:49 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-05-29 06:37:41 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b749a19570ce33a41e4cc792c19b4b21fdecbc71
Cr-Commit-Position: refs/heads/master@{#28692}