Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1157403005: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/websoc… (Closed)

Created:
5 years, 6 months ago by HariS
Modified:
5 years, 6 months ago
Reviewers:
Adam Rice
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/websockets BUG=457697 Committed: https://crrev.com/b87973c4cb97f079cd8781e2a7adbf88e1663678 Cr-Commit-Position: refs/heads/master@{#332185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M net/websockets/websocket_basic_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/websockets/websocket_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_channel_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_deflate_stream.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/websockets/websocket_frame_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
HariS
Please review the changes done.
5 years, 6 months ago (2015-06-01 10:56:16 UTC) #2
Adam Rice
lgtm Thank you for the cleanup.
5 years, 6 months ago (2015-06-01 12:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157403005/1
5 years, 6 months ago (2015-06-01 12:19:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 13:34:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 13:35:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b87973c4cb97f079cd8781e2a7adbf88e1663678
Cr-Commit-Position: refs/heads/master@{#332185}

Powered by Google App Engine
This is Rietveld 408576698