net/websockets/websocket_frame_parser.cc - Issue 1157403005: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/websoc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_frame_parser.cc

Issue 1157403005: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/websoc… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/websockets/websocket_frame_parser.cc

diff --git a/net/websockets/websocket_frame_parser.cc b/net/websockets/websocket_frame_parser.cc

index d00a1d11ae59bf9c547d47e63fa2141ff123e119..40d7e8a6e1098136b4c827191fec470c3c0ccfc2 100644

--- a/net/websockets/websocket_frame_parser.cc

+++ b/net/websockets/websocket_frame_parser.cc

@@ -72,7 +72,7 @@ bool WebSocketFrameParser::Decode(

scoped_ptr<WebSocketFrameChunk> frame_chunk =

DecodeFramePayload(first_chunk);

DCHECK(frame_chunk.get());

- frame_chunks->push_back(frame_chunk.release());

+ frame_chunks->push_back(frame_chunk.Pass());

if (current_frame_header_.get()) {

DCHECK(current_read_pos_ == buffer_.size());

« no previous file with comments | « net/websockets/websocket_deflate_stream.cc ('k') | net/websockets/websocket_stream_test.cc » ('j') | no next file with comments »