Issue 1157303008: Revert of move erase into SkPixmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157303008: Revert of move erase into SkPixmap (Closed)

Created:
5 years, 6 months ago by djsollen

Modified:
5 years, 6 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/1161033005/) Reason for revert: broken builds Original issue's description: > move erase into SkPixmap > > harvested from https://codereview.chromium.org/1148793007 > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -154 lines)			Patch
M	include/core/SkBitmap.h	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	include/core/SkPixmap.h	View	2 chunks	+0 lines, -34 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	2 chunks	+108 lines, -4 lines	0 comments	Download
M	src/core/SkPixmap.cpp	View	2 chunks	+8 lines, -106 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157303008/1

5 years, 6 months ago (2015-06-08 17:03:38 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-08 17:03:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a