Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1157303006: Prevent synthetic mouse moves from firing during trackpad scroll. (Closed)

Created:
5 years, 6 months ago by tdresser
Modified:
5 years, 5 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Prevent synthetic mouse moves from firing during trackpad scroll. Previously we dispatched synthetic mouse move events during trackpad and mousewheel scrolling. These events were throttled, but still caused significant jank on some pages. This patch prevents these synthetic mouse moves from being dispatched until the scroll is complete. Perf tryjob here: https://codereview.chromium.org/1213113003 Results here: http://storage.googleapis.com/chromium-telemetry/html-results/results-2015-06-29_10-43-42 BUG=317007 TEST=smoothness.tough_scrolling_cases/responsive-biggest_jank_thread_time Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198053

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -38 lines) Patch
M Source/core/input/EventHandler.cpp View 1 6 chunks +8 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdresser
The performance test is behaving correctly. http://storage.googleapis.com/chromium-telemetry/html-results/results-2015-06-29_10-43-42 Monitoring is on for: tasks_per_frame_raster, thread_total_all_cpu_time_per_frame, thread_raster_cpu_time_per_frame
5 years, 5 months ago (2015-06-29 17:49:07 UTC) #2
Rick Byers
Excellent, LGTM! Any chance we have an UMA metric we may see the benefits of ...
5 years, 5 months ago (2015-06-29 18:42:39 UTC) #3
tdresser
On 2015/06/29 18:42:39, Rick Byers wrote: > Excellent, LGTM! > > Any chance we have ...
5 years, 5 months ago (2015-06-29 18:54:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157303006/20001
5 years, 5 months ago (2015-06-30 11:54:28 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 11:57:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198053

Powered by Google App Engine
This is Rietveld 408576698