Issue 1157253009: Organize the tab helper file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157253009: Organize the tab helper file. (Closed)

Created:
5 years, 6 months ago by Avi (use Gerrit)

Modified:
5 years, 6 months ago

Reviewers:
qinmin, sky

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Organize the tab helper file. BUG=364522 TEST=no change Committed: https://crrev.com/7bb158502a6775aa3d94c619de933aa0f4e00bd6 Cr-Commit-Position: refs/heads/master@{#332622}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/tab_helpers.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Avi (use Gerrit)

Scott, I don't mind you approving changes to the tab helpers file, but please enforce ...

5 years, 6 months ago (2015-06-03 15:18:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157253009/1

5 years, 6 months ago (2015-06-03 16:09:00 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-03 16:15:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7bb158502a6775aa3d94c619de933aa0f4e00bd6
Cr-Commit-Position: refs/heads/master@{#332622}