Issue 115723003: Make GN write the platform for MSVS GYP files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115723003: Make GN write the platform for MSVS GYP files. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make GN write the platform for MSVS GYP files. This also updates the base GN build to stay in sync with the GYP one. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242078

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/gn/gyp_binary_target_writer.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
	M	tools/gn/secondary/base/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/115723003/1

7 years ago (2013-12-20 07:22:45 UTC) #3

Message was sent while issue was closed.

Change committed as 242078