Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: tools/gn/gyp_binary_target_writer.cc

Issue 115723003: Make GN write the platform for MSVS GYP files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/gyp_binary_target_writer.cc
diff --git a/tools/gn/gyp_binary_target_writer.cc b/tools/gn/gyp_binary_target_writer.cc
index 57977677a203d0c4bdc98ca91c5ab94a890df4fb..e32c60bff5a5a05deaeeb6de89e00e9f4143c1c9 100644
--- a/tools/gn/gyp_binary_target_writer.cc
+++ b/tools/gn/gyp_binary_target_writer.cc
@@ -162,11 +162,15 @@ void GypBinaryTargetWriter::WriteVCConfiguration(int indent) {
Indent(indent) << "'configurations': {\n";
Indent(indent + kExtraIndent) << "'Debug': {\n";
+ Indent(indent + kExtraIndent * 2) <<
+ "'msvs_configuration_platform': 'Win32',\n";
Flags debug_flags(FlagsFromTarget(group_.debug->item()->AsTarget()));
WriteVCFlags(debug_flags, indent + kExtraIndent * 2);
Indent(indent + kExtraIndent) << "},\n";
Indent(indent + kExtraIndent) << "'Release': {\n";
+ Indent(indent + kExtraIndent * 2) <<
+ "'msvs_configuration_platform': 'Win32',\n";
Flags release_flags(FlagsFromTarget(group_.release->item()->AsTarget()));
WriteVCFlags(release_flags, indent + kExtraIndent * 2);
Indent(indent + kExtraIndent) << "},\n";
@@ -175,6 +179,8 @@ void GypBinaryTargetWriter::WriteVCConfiguration(int indent) {
// confused, but we ca leave them empty if there's no 64-bit target.
Indent(indent + kExtraIndent) << "'Debug_x64': {\n";
if (group_.debug64) {
+ Indent(indent + kExtraIndent * 2) <<
+ "'msvs_configuration_platform': 'x64',\n";
Flags flags(FlagsFromTarget(group_.debug64->item()->AsTarget()));
WriteVCFlags(flags, indent + kExtraIndent * 2);
}
@@ -182,6 +188,8 @@ void GypBinaryTargetWriter::WriteVCConfiguration(int indent) {
Indent(indent + kExtraIndent) << "'Release_x64': {\n";
if (group_.release64) {
+ Indent(indent + kExtraIndent * 2) <<
+ "'msvs_configuration_platform': 'x64',\n";
Flags flags(FlagsFromTarget(group_.release64->item()->AsTarget()));
WriteVCFlags(flags, indent + kExtraIndent * 2);
}
« no previous file with comments | « no previous file | tools/gn/secondary/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698