Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: net/proxy/proxy_resolver_v8_tracing.cc

Issue 1157163003: Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-proxy-resolver-refactor
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_winhttp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_v8_tracing.cc
diff --git a/net/proxy/proxy_resolver_v8_tracing.cc b/net/proxy/proxy_resolver_v8_tracing.cc
index 0d6b467640e88c88ed26883be41acb1f21ced8cb..2f528e65edb1a24265767ec5c19947b10ed8f2fa 100644
--- a/net/proxy/proxy_resolver_v8_tracing.cc
+++ b/net/proxy/proxy_resolver_v8_tracing.cc
@@ -352,9 +352,6 @@ class ProxyResolverV8Tracing : public ProxyResolver,
const BoundNetLog& net_log) override;
void CancelRequest(RequestHandle request) override;
LoadState GetLoadState(RequestHandle request) const override;
- void CancelSetPacScript() override;
- int SetPacScript(const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& callback) override;
private:
// The worker thread on which the ProxyResolverV8 will be run.
@@ -1003,8 +1000,7 @@ ProxyResolverV8Tracing::ProxyResolverV8Tracing(
scoped_ptr<base::Thread> thread,
scoped_ptr<ProxyResolverV8> resolver,
scoped_ptr<Job::Params> job_params)
- : ProxyResolver(true /*expects_pac_bytes*/),
- thread_(thread.Pass()),
+ : thread_(thread.Pass()),
v8_resolver_(resolver.Pass()),
error_observer_(error_observer.Pass()),
job_params_(job_params.Pass()),
@@ -1048,17 +1044,6 @@ LoadState ProxyResolverV8Tracing::GetLoadState(RequestHandle request) const {
return job->GetLoadState();
}
-void ProxyResolverV8Tracing::CancelSetPacScript() {
- NOTREACHED();
-}
-
-int ProxyResolverV8Tracing::SetPacScript(
- const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& callback) {
- NOTREACHED();
- return ERR_NOT_IMPLEMENTED;
-}
-
} // namespace
class ProxyResolverFactoryV8Tracing::CreateJob
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_winhttp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698