Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart

Issue 1157113004: add enum suggestions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
index 7701bb8f0cb90200cd24eb2ad842b7fd287be297..598a58a4dba08eaaca844b216ef807971d849bdd 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
@@ -93,50 +93,32 @@ class _ConstructorVisitor extends LocalDeclarationVisitor {
}
@override
- void declaredClassTypeAlias(ClassTypeAlias declaration) {
- // TODO: implement declaredClassTypeAlias
- }
+ void declaredClassTypeAlias(ClassTypeAlias declaration) {}
@override
- void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
- // TODO: implement declaredField
- }
+ void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {}
@override
- void declaredFunction(FunctionDeclaration declaration) {
- // TODO: implement declaredFunction
- }
+ void declaredFunction(FunctionDeclaration declaration) {}
@override
- void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {
- // TODO: implement declaredFunctionTypeAlias
- }
+ void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {}
@override
- void declaredLabel(Label label, bool isCaseLabel) {
- // TODO: implement declaredLabel
- }
+ void declaredLabel(Label label, bool isCaseLabel) {}
@override
- void declaredLocalVar(SimpleIdentifier name, TypeName type) {
- // TODO: implement declaredLocalVar
- }
+ void declaredLocalVar(SimpleIdentifier name, TypeName type) {}
@override
- void declaredMethod(MethodDeclaration declaration) {
- // TODO: implement declaredMethod
- }
+ void declaredMethod(MethodDeclaration declaration) {}
@override
- void declaredParam(SimpleIdentifier name, TypeName type) {
- // TODO: implement declaredParam
- }
+ void declaredParam(SimpleIdentifier name, TypeName type) {}
@override
void declaredTopLevelVar(
- VariableDeclarationList varList, VariableDeclaration varDecl) {
- // TODO: implement declaredTopLevelVar
- }
+ VariableDeclarationList varList, VariableDeclaration varDecl) {}
/**
* For the given class and constructor,
@@ -405,6 +387,22 @@ class _LocalVisitor extends LocalDeclarationVisitor {
}
@override
+ void declaredEnum(EnumDeclaration declaration) {
+ SimpleIdentifier enumId = declaration.name;
+ if (enumId != null) {
+ bool deprecated = isDeprecated(declaration);
+ if (optype.includeTypeNameSuggestions) {
+ CompletionSuggestion suggestion = _addSuggestion(
+ enumId, NO_RETURN_TYPE, deprecated, DART_RELEVANCE_DEFAULT);
+ if (suggestion != null) {
+ suggestion.element = createElement(protocol.ElementKind.ENUM, enumId,
+ returnType: NO_RETURN_TYPE, isDeprecated: deprecated);
+ }
+ }
+ }
+ }
+
+ @override
void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
if (optype.includeReturnValueSuggestions) {
CompletionSuggestion suggestion =

Powered by Google App Engine
This is Rietveld 408576698