Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

Issue 1157113004: add enum suggestions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart b/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart
index 9032b05bd848d0078d81296fdaefe0f599731354..ac99637344d58ee62e743cc2cc3a8ce659176e84 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart
@@ -25,6 +25,8 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
void declaredClassTypeAlias(ClassTypeAlias declaration);
+ void declaredEnum(EnumDeclaration declaration) {}
+
void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl);
void declaredFunction(FunctionDeclaration declaration);
@@ -123,8 +125,7 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
if (declaration is ClassDeclaration) {
declaredClass(declaration);
} else if (declaration is EnumDeclaration) {
- // TODO (danrubel) enum support
-// declaredEnum(........)
+ declaredEnum(declaration);
} else if (declaration is FunctionDeclaration) {
declaredFunction(declaration);
} else if (declaration is TopLevelVariableDeclaration) {

Powered by Google App Engine
This is Rietveld 408576698