add enum suggestions

pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart

Index: pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
index 7701bb8f0cb90200cd24eb2ad842b7fd287be297..f58aa727e33a1146e55e9caf33eb15c2e3edd84b 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart
@@ -93,50 +93,32 @@ class _ConstructorVisitor extends LocalDeclarationVisitor {
   }
 
   @override
-  void declaredClassTypeAlias(ClassTypeAlias declaration) {
-    // TODO: implement declaredClassTypeAlias
-  }
+  void declaredClassTypeAlias(ClassTypeAlias declaration) {}
 
   @override
-  void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
-    // TODO: implement declaredField
-  }
+  void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {}
 
   @override
-  void declaredFunction(FunctionDeclaration declaration) {
-    // TODO: implement declaredFunction
-  }
+  void declaredFunction(FunctionDeclaration declaration) {}
 
   @override
-  void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {
-    // TODO: implement declaredFunctionTypeAlias
-  }
+  void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {}
 
   @override
-  void declaredLabel(Label label, bool isCaseLabel) {
-    // TODO: implement declaredLabel
-  }
+  void declaredLabel(Label label, bool isCaseLabel) {}
 
   @override
-  void declaredLocalVar(SimpleIdentifier name, TypeName type) {
-    // TODO: implement declaredLocalVar
-  }
+  void declaredLocalVar(SimpleIdentifier name, TypeName type) {}
 
   @override
-  void declaredMethod(MethodDeclaration declaration) {
-    // TODO: implement declaredMethod
-  }
+  void declaredMethod(MethodDeclaration declaration) {}
 
   @override
-  void declaredParam(SimpleIdentifier name, TypeName type) {
-    // TODO: implement declaredParam
-  }
+  void declaredParam(SimpleIdentifier name, TypeName type) {}
 
   @override
   void declaredTopLevelVar(
-      VariableDeclarationList varList, VariableDeclaration varDecl) {
-    // TODO: implement declaredTopLevelVar
-  }
+      VariableDeclarationList varList, VariableDeclaration varDecl) {}
 
   /**
    * For the given class and constructor,
@@ -405,6 +387,23 @@ class _LocalVisitor extends LocalDeclarationVisitor {
   }
 
   @override
+  void declaredEnum(EnumDeclaration declaration) {

[Paul Berry, 2015/05/29 17:55:57]

This method looks almost identical to the two methods above it.  Would you mind
extracting a method with the common parts?

[danrubel, 2015/06/01 04:26:56]

Good point. Will do in a subsequent CL so as not to clutter this one.

[danrubel, 2015/06/04 17:55:52]

https://codereview.chromium.org/1163973004/

+    SimpleIdentifier enumId = declaration.name;
+    if (enumId != null) {
+      bool deprecated = isDeprecated(declaration);
+      if (optype.includeTypeNameSuggestions) {
+        CompletionSuggestion suggestion = _addSuggestion(
+            enumId, NO_RETURN_TYPE, deprecated, DART_RELEVANCE_DEFAULT);
+        if (suggestion != null) {
+          suggestion.element = createElement(
+              protocol.ElementKind.ENUM, enumId,
+              returnType: NO_RETURN_TYPE, isDeprecated: deprecated);
+        }
+      }
+    }
+  }
+
+  @override
   void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
     if (optype.includeReturnValueSuggestions) {
       CompletionSuggestion suggestion =
@@ -597,9 +596,11 @@ class _LocalVisitor extends LocalDeclarationVisitor {
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName returnType,
-      bool isDeprecated, int defaultRelevance, {ClassDeclaration classDecl}) {
+      bool isDeprecated, int defaultRelevance,
+      {ClassDeclaration classDecl, SimpleIdentifier enumName}) {
     CompletionSuggestion suggestion = createSuggestion(
-        id, isDeprecated, defaultRelevance, returnType, classDecl: classDecl);
+        id, isDeprecated, defaultRelevance, returnType,
+        classDecl: classDecl, enumName: enumName);
     if (suggestion != null) {
       request.addSuggestion(suggestion);
     }