add enum suggestions

pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol
     show Element, ElementKind;
@@ skipping 75 matching lines @@
         found = true;
         _addSuggestion(declaration, member);
       }
     }
     if (!found) {
       _addSuggestion(declaration, null);
     }
   }
 
   @override
-  void declaredClassTypeAlias(ClassTypeAlias declaration) {
-    // TODO: implement declaredClassTypeAlias
-  }
+  void declaredClassTypeAlias(ClassTypeAlias declaration) {}
 
   @override
-  void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
-    // TODO: implement declaredField
-  }
+  void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {}
 
   @override
-  void declaredFunction(FunctionDeclaration declaration) {
-    // TODO: implement declaredFunction
-  }
+  void declaredFunction(FunctionDeclaration declaration) {}
 
   @override
-  void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {
-    // TODO: implement declaredFunctionTypeAlias
-  }
+  void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {}
 
   @override
-  void declaredLabel(Label label, bool isCaseLabel) {
-    // TODO: implement declaredLabel
-  }
+  void declaredLabel(Label label, bool isCaseLabel) {}
 
   @override
-  void declaredLocalVar(SimpleIdentifier name, TypeName type) {
-    // TODO: implement declaredLocalVar
-  }
+  void declaredLocalVar(SimpleIdentifier name, TypeName type) {}
 
   @override
-  void declaredMethod(MethodDeclaration declaration) {
-    // TODO: implement declaredMethod
-  }
+  void declaredMethod(MethodDeclaration declaration) {}
 
   @override
-  void declaredParam(SimpleIdentifier name, TypeName type) {
-    // TODO: implement declaredParam
-  }
+  void declaredParam(SimpleIdentifier name, TypeName type) {}
 
   @override
   void declaredTopLevelVar(
-      VariableDeclarationList varList, VariableDeclaration varDecl) {
-    // TODO: implement declaredTopLevelVar
-  }
+      VariableDeclarationList varList, VariableDeclaration varDecl) {}
 
   /**
    * For the given class and constructor,
    * add a suggestion of the form B(...) or B.name(...).
    * If the given constructor is `null`
    * then add a default constructor suggestion.
    */
   CompletionSuggestion _addSuggestion(
       ClassDeclaration classDecl, ConstructorDeclaration constructorDecl) {
     SimpleIdentifier elemId;
@@ skipping 248 matching lines @@
         suggestion.element = createElement(
             protocol.ElementKind.CLASS_TYPE_ALIAS, declaration.name,
             returnType: NO_RETURN_TYPE,
             isAbstract: true,
             isDeprecated: deprecated);
       }
     }
   }
 
   @override
+  void declaredEnum(EnumDeclaration declaration) {

[Paul Berry, 2015/05/29 17:55:57]

This method looks almost identical to the two methods above it.  Would you mind
extracting a method with the common parts?

[danrubel, 2015/06/01 04:26:56]

Good point. Will do in a subsequent CL so as not to clutter this one.

[danrubel, 2015/06/04 17:55:52]

https://codereview.chromium.org/1163973004/

+    SimpleIdentifier enumId = declaration.name;
+    if (enumId != null) {
+      bool deprecated = isDeprecated(declaration);
+      if (optype.includeTypeNameSuggestions) {
+        CompletionSuggestion suggestion = _addSuggestion(
+            enumId, NO_RETURN_TYPE, deprecated, DART_RELEVANCE_DEFAULT);
+        if (suggestion != null) {
+          suggestion.element = createElement(
+              protocol.ElementKind.ENUM, enumId,
+              returnType: NO_RETURN_TYPE, isDeprecated: deprecated);
+        }
+      }
+    }
+  }
+
+  @override
   void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
     if (optype.includeReturnValueSuggestions) {
       CompletionSuggestion suggestion =
           createFieldSuggestion(fieldDecl, varDecl);
       if (suggestion != null) {
         request.addSuggestion(suggestion);
       }
     }
   }
 
@@ skipping 172 matching lines @@
       }
       return typeId.name;
     }).toList();
     suggestion.requiredParameterCount = paramList.where(
         (FormalParameter param) => param is! DefaultFormalParameter).length;
     suggestion.hasNamedParameters = paramList
         .any((FormalParameter param) => param.kind == ParameterKind.NAMED);
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName returnType,
-      bool isDeprecated, int defaultRelevance, {ClassDeclaration classDecl}) {
+      bool isDeprecated, int defaultRelevance,
+      {ClassDeclaration classDecl, SimpleIdentifier enumName}) {
     CompletionSuggestion suggestion = createSuggestion(
-        id, isDeprecated, defaultRelevance, returnType, classDecl: classDecl);
+        id, isDeprecated, defaultRelevance, returnType,
+        classDecl: classDecl, enumName: enumName);
     if (suggestion != null) {
       request.addSuggestion(suggestion);
     }
     return suggestion;
   }
 
   bool _isVoid(TypeName returnType) {
     if (returnType != null) {
       Identifier id = returnType.name;
       if (id != null && id.name == 'void') {
         return true;
       }
     }
     return false;
   }
 }